Skip to content

Commit

Permalink
Update exclude to be a kwarg
Browse files Browse the repository at this point in the history
  • Loading branch information
Michael Becker committed Apr 10, 2020
1 parent c153e8f commit 2cd64e3
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[BASIC]
good-names=a,b,c,d,df,i,logger,n,tz
good-names=a,b,c,d,df,i,logger,n,on,tz

[MASTER]
ignore=ci,docs
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

MONGO_REQUIRES = ("pymongo",)

MSSQL_REQUIRES = ("pymssql<3.0", "sqlalchemy")
MSSQL_REQUIRES = ("cython", "pymssql<3.0", "sqlalchemy")

KEYWORDS = (
# eg: 'keyword1', 'keyword2', 'keyword3',
Expand Down
7 changes: 3 additions & 4 deletions src/dsdk/mongo.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,10 @@ def open_batch(
with self.open_mongo() as database:
update_one(database.batches, key, doc)

def store_evidence(
self, batch: Batch, *args, exclude: Sequence[str] = ()
) -> None:
def store_evidence(self, batch: Batch, *args, **kwargs) -> None:
"""Store Evidence."""
super().store_evidence(batch, *args, exclude)
super().store_evidence(batch, *args, **kwargs)
exclude = kwargs.get("exclude", ())
while args:
key, df, *args = args # type: ignore
# TODO We need to check column types and convert as needed
Expand Down
2 changes: 1 addition & 1 deletion src/dsdk/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def open_batch( # pylint: disable=no-self-use,unused-argument
record.end = datetime.now(timezone.utc)

def store_evidence( # pylint: disable=no-self-use,unused-argument
self, batch: Batch, *args, exclude: Sequence[str] = ()
self, batch: Batch, *args, **kwargs
) -> None:
"""Store evidence."""
while args:
Expand Down

0 comments on commit 2cd64e3

Please sign in to comment.