Skip to content
This repository was archived by the owner on Apr 10, 2025. It is now read-only.

fix: #268: disable slider for empty balances #275

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

VanishMax
Copy link
Member

Closes #268

  • Disables the Slider if the balance of controlled asset is empty. Tried removing Slider but disabling is better UI
  • For 'Sell' tab, uses base asset instead of quote asset
image

@VanishMax VanishMax requested a review from a team January 16, 2025 06:38
@VanishMax VanishMax self-assigned this Jan 16, 2025
@@ -82,8 +83,8 @@ export const MarketOrderForm = observer(({ parentStore }: { parentStore: OrderFo
/>
</div>
<Slider
inputValue={store.quoteInput}
balance={store.quoteBalance}
inputValue={isBuy ? store.quoteInput : store.baseInput}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, lgtm

@VanishMax VanishMax merged commit 3bc17e7 into main Jan 16, 2025
3 checks passed
@VanishMax VanishMax deleted the fix/#268-slider branch January 16, 2025 07:08
TalDerei pushed a commit to penumbra-zone/web that referenced this pull request Mar 10, 2025
TalDerei pushed a commit to penumbra-zone/web that referenced this pull request Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Market order form slider stops working if a subaccount is selected
2 participants