fix: we can withdraw auto-closing positions #295
Conversation
|
linted the changeset. unrelated, but why can't I still close this pesky position? Screen.Recording.2025-01-20.at.2.18.58.PM.mov |
|
Thanks, @TalDerei can you share the output of |
| } | ||
|
|
||
| // Query the balance, ignoring the subaccount index for now. | ||
| const balances = await asyncIterableToArray(penumbra.service(ViewService).balances({})); |
There was a problem hiding this comment.
Here you can do:
| const balances = await asyncIterableToArray(penumbra.service(ViewService).balances({})); | |
| const balances = await Array.fromAsync(penumbra.service(ViewService).balances({})); |
There was a problem hiding this comment.
It seems we have a useBalances hook in src/shared/api/balances.ts. I feel like we should probably reuse that, that one also accept the account index to fetch the balances by the selected sub account.
There was a problem hiding this comment.
I think you can ignore this last comment, as the positions table currently doesn't do filtering by sub accounts yet.
| } | ||
|
|
||
| // TODO(jason): not sure if this is duplicating code, feel free to move it out somewhere less disruptive. | ||
| async function asyncIterableToArray<T>(asyncIterable: AsyncIterable<T>): Promise<T[]> { |
There was a problem hiding this comment.
You can remove this in favor of the comment below:
There was a problem hiding this comment.
Can you take the PR over, I'm working on something else and seems like you would be effective at pushing this across the finish line
|
|
@TalDerei ah yes, the LP is in account 1. The closing flow is broken in that case. It will be easy to fix once we ship the alpha and implement penumbra-zone/penumbra#4992 |
This PR fix withdrawals of auto-closing positions (#241).
Unfortunately, the approach we workshopped in #282 does not work because the
PositionStoreis already given a list of positions directly fetched from the DEX RPC service (latest state). This was an oversight on my part.The code is hacky, maybe one could say that it sucks (?), but it works and we should spend no time trying to make it structurally better. We can fix linting, but let's keep it minimal. Our attention should be directed to the opened TODOs.