This repository was archived by the owner on Apr 10, 2025. It is now read-only.
Chart #75
Merged
Chart #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/v2/trade/chart/index.tsx
Outdated
| height: number; | ||
| } | ||
|
|
||
| const asset1: Token = { |
There was a problem hiding this comment.
Temporarily hardcoded
VanishMax
reviewed
Oct 4, 2024
| heights?: string[]; | ||
| } | ||
|
|
||
| export default async function blockInfoFetchHandler(req: NextApiRequest, res: NextApiResponse) { |
There was a problem hiding this comment.
suggestion: move this into the app directory while applying the newer NextJS's API.
I believe we should discontinue supporting the pages directory and move everything related to v2 to the app. It's not just the new API but also, if done correctly, a performance increase.
Merged
TalDerei
pushed a commit
to penumbra-zone/web
that referenced
this pull request
Mar 10, 2025
* Setup responsive trade layout * Adjust column widths * Add lightweight chart' * Refactor ohlc api * Refactor api/blocks & add block fetcher * Create useCandles hook * Add path support for ca env * Refactor candles fetchers * Move ohlc api to candles * Move merge candles logic to api route * Tmp move block info logic to candles api route * Move block info logic to api route * Fix types for candles api routes * Remove IChartApi type * Move assets outside of useCandles * Remove console logs * Remove hook useCandles * Address PR comments * Fix import paths * Add penumbra chain id to candles api route
TalDerei
pushed a commit
to penumbra-zone/web
that referenced
this pull request
Mar 25, 2025
* Setup responsive trade layout * Adjust column widths * Add lightweight chart' * Refactor ohlc api * Refactor api/blocks & add block fetcher * Create useCandles hook * Add path support for ca env * Refactor candles fetchers * Move ohlc api to candles * Move merge candles logic to api route * Tmp move block info logic to candles api route * Move block info logic to api route * Fix types for candles api routes * Remove IChartApi type * Move assets outside of useCandles * Remove console logs * Remove hook useCandles * Address PR comments * Fix import paths * Add penumbra chain id to candles api route
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the lightweight-charts lib of tradingview.
candlesapi route. The implementation is slightly updated to start at the end height and go backwards.