Skip to content

Commit

Permalink
Revert "penumbra: update ecosystem tendermint/ibc crates (#4980)" (#4993
Browse files Browse the repository at this point in the history
)

## Describe your changes
This reverts commit 64c32ef, which
constitutes the squash-merge of PR #4980. We're backing this change out
strictly to simplify release engineering: we want the `main` branch to
remain fully compatible with the `0.81.x` series, and we'll continue QA
of significant version changes in a parallel release branch,
`release/v0.82.x`. I'll handle preparing the latter shortly.

## Issue ticket number and link

See related discussion in #4988 & #4991.

## Testing and review

This is a programmatic change, in that I simply ran `git revert
64c32ef`, wrote some notes into the commit message, and pushed it up.
I also made sure to rerun `just proto` to regenerate the protos, and
confirmed there are no changes. That's good, that's precisely what we
wanted to see.

Preferably this change would land before #4992, since #4992 changes
protos. I'll regenerate protos in 4992 on top of this once it lands on
main.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

> This commit is expressly intended to preserve protocol compatibility
with 0.81.x. Future work on QA to ensure compat with 0.82 will happen in
a separate branch.
  • Loading branch information
conorsch authored Jan 17, 2025
1 parent 1781508 commit a454870
Show file tree
Hide file tree
Showing 173 changed files with 19,947 additions and 6,439 deletions.
1 change: 1 addition & 0 deletions .github/workflows/buf-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ jobs:
./deployments/scripts/protobuf-codegen
# https://github.com/penumbra-zone/penumbra/issues/3038#issuecomment-1722534133
git checkout crates/proto/src/gen/proto_descriptor.bin.no_lfs
git checkout crates/cnidarium/src/gen/proto_descriptor.bin.no_lfs
s="$(git status --porcelain)"
if [[ -n "$s" ]]; then
echo "ERROR: protobuf files must be regenerated and committed."
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
fi
- name: Run tests with nextest
run: cargo nextest run --release
run: cargo nextest run --release --features migration
env:
CARGO_TERM_COLOR: always

Expand Down
Loading

0 comments on commit a454870

Please sign in to comment.