Skip to content

Commit

Permalink
fix(pd): restore metrics-process emission (#5022)
Browse files Browse the repository at this point in the history
## Describe your changes
In bumping the various metrics-related crates recently, we overlooked
that the specific metrics emitted by the `metrics-process` crate had
vanished. Bumping the dependency resolves.

Updates the pd metrics tests to check for more patterns. These checks
were failing on the main branch, specifically the `pd_process_*`
patterns.

Also refactors the metrics test to use `rstest`, for more granular
output.

## Issue ticket number and link

Refs #5021

## Testing and review

I've already confirmed that the new tests failed on main, so CI passing
is enough to merge here.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > metrics and tests only, does not affect consensus logic
  • Loading branch information
conorsch authored Jan 29, 2025
1 parent bc912f0 commit e8b4a9b
Show file tree
Hide file tree
Showing 5 changed files with 65 additions and 79 deletions.
105 changes: 44 additions & 61 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ rand_chacha = { version = "0.3.1" }
rand_core = { version = "0.6.4" }
regex = { version = "1.8.1" }
rocksdb = { version = "0.21.0" }
rstest = { version = "0.24.0" }
rustls = { version = "0.23.21" }
serde = { version = "1.0.186" }
serde_json = { version = "1.0.96" }
Expand Down
3 changes: 2 additions & 1 deletion crates/bin/pd/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ ics23 = { workspace = true }
jmt = { workspace = true }
metrics = { workspace = true }
metrics-exporter-prometheus = { workspace = true }
metrics-process = "2.0.0"
metrics-process = "2.4.0"
metrics-tracing-context = { workspace = true }
metrics-util = "0.18.0"
mime_guess = "2"
Expand Down Expand Up @@ -127,3 +127,4 @@ assert_cmd = { workspace = true }
predicates = "2.1"
prost-reflect = "0.14.3"
regex = { workspace = true }
rstest = { workspace = true }
Loading

0 comments on commit e8b4a9b

Please sign in to comment.