Governance indexing #4774
Closed
Governance indexing #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly redundant, but the governance indexer wants this, so we can have it too.
Co-authored-by: plaidfinch <plaidfinch@users.noreply.github.com>
cronokirby
force-pushed
the
governance-indexing
branch
from
8b6a238 to
fc7417c
Compare
|
Closing in favor of the original work in #4708 which powers the governance frontend. |
hdevalence
reviewed
Jul 26, 2024
Comment on lines
+17
to
+20
| /// One of the possible events that we care about. | ||
| #[derive(Clone, Debug)] | ||
| enum Event { | ||
| ProposalSubmit { |
There was a problem hiding this comment.
We don't need to define an event enum here. Processing the events, as in the original code, works fine.
hdevalence
reviewed
Jul 26, 2024
Comment on lines
+1
to
+55
| CREATE TABLE IF NOT EXISTS governance_proposals ( | ||
| proposal_id INTEGER PRIMARY KEY, | ||
| title TEXT NOT NULL, | ||
| description TEXT NOT NULL, | ||
| kind JSONB NOT NULL, | ||
| payload JSONB, | ||
| start_block_height BIGINT NOT NULL, | ||
| end_block_height BIGINT NOT NULL, | ||
| state JSONB NOT NULL, | ||
| proposal_deposit_amount BIGINT NOT NULL, | ||
| withdrawn BOOLEAN DEFAULT FALSE, | ||
| withdrawal_reason TEXT | ||
| ); | ||
|
|
||
| CREATE INDEX ON governance_proposals (title text_pattern_ops); | ||
| CREATE INDEX ON governance_proposals (kind); | ||
| CREATE INDEX ON governance_proposals (start_block_height DESC); | ||
| CREATE INDEX ON governance_proposals (end_block_height DESC); | ||
| CREATE INDEX ON governance_proposals (state); | ||
| CREATE INDEX ON governance_proposals (withdrawn); | ||
|
|
||
|
|
||
| CREATE TABLE IF NOT EXISTS governance_validator_votes ( | ||
| id SERIAL PRIMARY KEY, | ||
| proposal_id INTEGER NOT NULL, | ||
| identity_key TEXT NOT NULL, | ||
| vote JSONB NOT NULL, | ||
| voting_power BIGINT NOT NULL, | ||
| block_height BIGINT NOT NULL, | ||
| FOREIGN KEY (proposal_id) REFERENCES governance_proposals(proposal_id) | ||
| ); | ||
|
|
||
| CREATE INDEX ON governance_validator_votes (proposal_id); | ||
| CREATE INDEX ON governance_validator_votes (identity_key); | ||
| CREATE INDEX ON governance_validator_votes (vote); | ||
| CREATE INDEX ON governance_validator_votes (voting_power); | ||
| CREATE INDEX ON governance_validator_votes (block_height); | ||
|
|
||
|
|
||
| CREATE TABLE IF NOT EXISTS governance_delegator_votes ( | ||
| id SERIAL PRIMARY KEY, | ||
| proposal_id INTEGER NOT NULL, | ||
| identity_key TEXT NOT NULL, | ||
| vote JSONB NOT NULL, | ||
| voting_power BIGINT NOT NULL, | ||
| block_height BIGINT NOT NULL, | ||
| FOREIGN KEY (proposal_id) REFERENCES governance_proposals(proposal_id) | ||
| ); | ||
|
|
||
| CREATE INDEX ON governance_delegator_votes (proposal_id); | ||
| CREATE INDEX ON governance_delegator_votes (identity_key); | ||
| CREATE INDEX ON governance_delegator_votes (vote); | ||
| CREATE INDEX ON governance_delegator_votes (voting_power); | ||
| CREATE INDEX ON governance_delegator_votes (block_height); | ||
|
|
There was a problem hiding this comment.
Not doing this was already discussed in the original PR: #4708 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should supercede #4708, now that the event changes have landed.
I took the structure in there, and munged it a bit to fit the current framework we use in the reset of the indexer code.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: