Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quotation mark #4974

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix quotation mark
  • Loading branch information
taozui472 committed Dec 25, 2024
commit 5c2f721ab51227a735edcfad7ecf3cbc3b179f7a
Original file line number Diff line number Diff line change
@@ -33,8 +33,8 @@ pub(crate) trait AssetByLiquidityIndex: StateWrite {
/// There are then two possible amounts to consider for an asset B: amount of A that
/// can be sold for B and amount of A that can be bought with B
///
/// (1), amount that can be sold (outbound) is the wrong thing to use
/// (2), amount that can be bought, is intuitively the opposite of what we want,
/// (1), amount that can be sold ("outbound") is the wrong thing to use
/// (2), amount that can be bought, is intuitively the "opposite" of what we want,
/// since it’s the reverse direction, but is actually the right thing to use as
/// a rough proxy for liquidity
///
4 changes: 2 additions & 2 deletions crates/custody/src/client.rs
Original file line number Diff line number Diff line change
@@ -14,8 +14,8 @@ use crate::AuthorizeRequest;
/// a transaction they’ve constructed.
///
/// Modeling transaction authorization as an asynchronous RPC call encourages
/// software to be written in a way that has a compatible data flow with a soft
/// HSM, threshold signing, a hardware wallet, etc.
/// software to be written in a way that has a compatible data flow with a "soft
/// HSM", threshold signing, a hardware wallet, etc.
///
/// The custody protocol does not trust the client to authorize spends, so
/// custody requests must contain sufficient information for the custodian to
2 changes: 1 addition & 1 deletion docs/protocol/src/sct/tct.md
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ means too many expensive hash operations, whereas an octal tree means too large
proofs.

* *Sparse:* A client’s version of the tree need only represent the state
commitments pertinent to that client’s state, with all other forgotten
commitments pertinent to that client’s state, with all other "forgotten"
commitments and internal hashes related to them pruned to a single summary hash.

* *Semi-Lazy:* The internal hashes along the frontier of the tree are only
4 changes: 2 additions & 2 deletions testnets/cometbft_config_template.toml
Original file line number Diff line number Diff line change
@@ -410,11 +410,11 @@ wal_file = "data/cs.wal/wal"
timeout_propose = "3s"
# How much timeout_propose increases with each round
timeout_propose_delta = "500ms"
# How long we wait after receiving +2/3 prevotes for anything (ie. not a single block or nil)
# How long we wait after receiving +2/3 prevotes for "anything" (ie. not a single block or nil)
timeout_prevote = "1s"
# How much the timeout_prevote increases with each round
timeout_prevote_delta = "500ms"
# How long we wait after receiving +2/3 precommits for anything (ie. not a single block or nil)
# How long we wait after receiving +2/3 precommits for "anything" (ie. not a single block or nil)
timeout_precommit = "1s"
# How much the timeout_precommit increases with each round
timeout_precommit_delta = "500ms"
Loading