Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pindexer): support big amounts #4982

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(pindexer): support big amounts #4982

merged 1 commit into from
Jan 13, 2025

Conversation

conorsch
Copy link
Contributor

Describe your changes

Use I256 values in pindexer.

Issue ticket number and link

N/A

Testing and review

I've already validated that the patch works when indexing against testnet; now I'd like to have @cronokirby's eyes on it to confirm it's a sane approach.

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    indexing-only

Use I256 values in pindexer.
Copy link
Contributor

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, everything should have the same behavior

@conorsch conorsch merged commit 539cf4a into main Jan 13, 2025
14 checks passed
@conorsch conorsch deleted the pindexer-big-amounts branch January 13, 2025 19:18
@conorsch conorsch mentioned this pull request Jan 16, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants