dex: hotfix for 2025-01-18 chain halt (alternative) #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit message and description TK
erwanor
reviewed
Jan 18, 2025
| } | ||
| .to_proto(), | ||
| ); | ||
| state.queue_close_position(self.position_id).await?; |
erwanor
reviewed
Jan 18, 2025
| .ok_or_else(|| anyhow::anyhow!("could not find position {} to close", id))? | ||
| .tap(|lp| tracing::trace!(prev_state = ?lp, "retrieved previous lp state")); | ||
|
|
||
| if current_state.state == position::State::Opened { |
There was a problem hiding this comment.
ACK. short-circuit on queueing.
erwanor
reviewed
Jan 18, 2025
| ); | ||
| let mut to_close = self.pending_position_closures(); | ||
| to_close.push_back(id); | ||
| self.object_put(state_key::pending_position_closures(), to_close); |
There was a problem hiding this comment.
ACK. queuing gated on valid state antecedent.
erwanor
reviewed
Jan 18, 2025
| // queue position close you will... | ||
| self.record_proto(event::EventQueuePositionClose { position_id: id }.to_proto()); | ||
| } else { | ||
| tracing::debug!( |
There was a problem hiding this comment.
ACK. no-op on contentious state antecedent.
erwanor
approved these changes
Jan 18, 2025
conorsch
pushed a commit
that referenced
this pull request
Jan 19, 2025
## Describe your changes This commit fixes the chain halt that occurred on 2025-01-18 at block 3093519. ### What happened (short version): A transaction was submitted that contained both `PositionClose` and `PositionWithdraw` actions for the same position `P`, which had been auto-closed by the DEX. In `DeliverTx`, the `PositionClose` action queued the position for closure by ID, and the `PositionWithdraw` action checked that the position state was closed and then updated it to Withdrawn. Later, in `EndBlock`, the queued position closure was executed. The position state was not Opened or Closed, triggering an assertion. ### Why it happened - Mempool tx checking does not execute end block so this didn't get filtered out - The position closure method allows the position closure to be a no-op, but only for positions in the closed state - Because the position was withdrawn, the state was unexpected ### What this does Avoid queueing the position for closure unless it is Opened. (cherry picked from commit f7f780d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This commit fixes the chain halt that occurred on 2025-01-18 at block 3093519.
What happened (short version):
A transaction was submitted that contained both
PositionCloseandPositionWithdrawactions for the same positionP, which had been auto-closed by the DEX. InDeliverTx, thePositionCloseaction queued the position for closure by ID, and thePositionWithdrawaction checked that the position state was closed and then updated it to Withdrawn. Later, inEndBlock, the queued position closure was executed. The position state was not Opened or Closed, triggering an assertion.Why it happened
What this does
Avoid queueing the position for closure unless it is Opened.