cometindex: make transactions available in event batches #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also refactors things to be a bit more opaque, giving us more control over the internal representation of the batch of events. The ContextualizedEvent struct is probably a little over-engineered, but avoids needlessly copying the transaction data around. Ultimately the performance of indexing is tied to data throughput, so we should be mindful of needless copying in the architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raw ABCI event database already has all the transaction data, and this PR amends our processing pipeline in cometindex to present blocks containing both a list of events, each of which may directly have all of this transaction data (along with a transaction hash), and a list of all the transactions themselves.
This also refactors things to be a bit more opaque, giving us more control over the internal representation of the batch of events.
The
ContextualizedEventstruct is probably a little over-engineered, but avoids needlessly copying the transaction data around. Ultimately the performance of indexing is tied to data throughput, so we should be mindful of needless copying in the architecture.This should help with the draft in #5081, avoiding the need for creating a bespoke event.
I tested this by setting up a little indexer just parsing out the tx data and serializing the JSON, and
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: