fix: latest swaps (#2019)

* fix pick initial swap block height for latestSwaps * chore: changeset * fix: tests
penumbra-zone · Feb 4, 2025 · dd09e58 · dd09e58
1 parent 68b8f36
commit dd09e58
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/curvy-buses-doubt.md b/.changeset/curvy-buses-doubt.md
@@ -0,0 +1,5 @@
+---
+'@penumbra-zone/services': patch
+---
+
+Fix latestSwaps method by picking initial swap block height instead of claim height
diff --git a/packages/services/src/view-service/latest-swaps.test.ts b/packages/services/src/view-service/latest-swaps.test.ts
@@ -321,6 +321,7 @@ const getSwap = ({ account, to, from, height, input, output }: GetSwapOptions) =
       claimAddress: getAddressByIndex(testFullViewingKey, account),
     },
     outputData: {
+      height: BigInt(height),
       tradingPair: {
         asset1: from.penumbraAssetId,
         asset2: to.penumbraAssetId,

diff --git a/packages/services/src/view-service/latest-swaps.ts b/packages/services/src/view-service/latest-swaps.ts
@@ -42,7 +42,7 @@ export const latestSwaps: Impl['latestSwaps'] = async function* (_req, ctx) {
       counter++;
       yield {
         id: new TransactionId({ inner: swapRecord.source.source.value.id }),
-        blockHeight: swapRecord.heightClaimed,
+        blockHeight: swapRecord.outputData.height,
         pair: new DirectedTradingPair({
           start: swapRecord.outputData.tradingPair.asset1,
           end: swapRecord.outputData.tradingPair.asset2,