feat: transaction summary #2000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f1750dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
VanishMax
reviewed
Feb 21, 2025
VanishMax
reviewed
Feb 22, 2025
| @@ -2,4 +2,4 @@ | |||
| * The version number for the IndexedDB schema. This version number is used to manage | |||
| * database upgrades and ensure that the correct schema version is applied. | |||
| */ | |||
| export const IDB_VERSION = 49; | |||
| export const IDB_VERSION = 50; | |||
There was a problem hiding this comment.
question: what happens if we don't bump this version? The changes seem to be backwards compatible and would work without resync... or not?
VanishMax
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
transaction summary scaffolding that will be hooked into #2051. It remained a draft until the
TransactionSummaryUI components are ready.Related Issue
references penumbra-zone/penumbra#4943 and #1394
Checklist Before Requesting Review