Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock-chrome improvements, transport-chrome test improvements #2090

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

turbocrime
Copy link
Collaborator

improved mock-chrome:

  • reduced need for redefining types (mock is more correct)
  • eliminated exported redefinitions

improved transport-chrome tests

  • don't use mock-chrome type redefinitions
  • no longer mocking console.warn in tests
  • relocated some test utils
  • introduced vi.waitFor timeouts to reduce test waiting
  • added a failing test for one future improvement

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 0646432

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@repo/mock-chrome Minor
@penumbra-zone/transport-chrome Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant