Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cancel link #177

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

add cancel link #177

wants to merge 2 commits into from

Conversation

The-Ludwig
Copy link
Contributor

fixes #33

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Merging #177 (92d2982) into master (050a8d1) will decrease coverage by 0.04%.
The diff coverage is 76.00%.

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   75.46%   75.43%   -0.04%     
==========================================
  Files          23       23              
  Lines        1011     1034      +23     
==========================================
+ Hits          763      780      +17     
- Misses        248      254       +6     
Impacted Files Coverage Δ
member_database/events/__init__.py 63.11% <76.00%> (+1.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxnoe
Copy link
Member

maxnoe commented Jan 25, 2023

Hi, we discussed this offline in the past (sorry, the issue was not updated).

Main points were that this is probably too complex to have the logic properly in the application and instead use human intervention for this part.

Some aspects that would need to be addressed:

  • Simply cancelling should only be possible up to a certain date before an event

  • Canceling should generate an email also to the event organizer

  • If a person cancels and there is a waiting list, the next person on the waiting list should be contacted that there is a spot available again. What happens if that person does not respond? Responds that it cannot take the place? How much time do we give to respond? This requires a "cron-like" background task, something more complex web-apps regularly have, but which we did not yet need until now.

So to be honest, I think for the time being it is best to have canceling via a human performing the necessary actions (sending emails, using the admin interface to update the db)

Copy link
Member

@maxnoe maxnoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above...

@maxnoe maxnoe marked this pull request as draft January 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event registration canceling
3 participants