Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try importlib.metadata as alternative to pkg_resources #68

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

vreuter
Copy link
Member

@vreuter vreuter commented Mar 4, 2024

Close #67

This modernises the dependency, and (selfishly) this would allow me re-update a major dependency in another project.

@vreuter
Copy link
Member Author

vreuter commented Mar 4, 2024

Note to reviewer(s): real changes are just in eido/conversion.py and requirements/requirements.txt. Other changes are just from applying black

Copy link
Contributor

@donaldcampbelljr donaldcampbelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and seems reasonable.

@vreuter vreuter changed the title Try importlib.metadata as alternative to pkg_resources Try importlib.metadata as alternative to pkg_resources Mar 4, 2024
@donaldcampbelljr
Copy link
Contributor

This received verbal approval at today's infrastructure meeting. Merging to dev.

@donaldcampbelljr donaldcampbelljr merged commit 68ac5b2 into pepkit:dev Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants