Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefetch check #133

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Prefetch check #133

merged 1 commit into from
Feb 4, 2024

Conversation

pedro-w
Copy link
Contributor

@pedro-w pedro-w commented Feb 2, 2024

As discussed in #130 here is my idea for checking if prefetch is installed and on the path. It doesn't require command or where to be installed. I tested on Windows and Linux.
Note I started this PR from the as-yet-unreleased V_0_12_6 branch therefore it shows quite a few diffs compared to master. The only file I changed was geofetch.py.
Please can you have a check and see if it looks suitable?
Thanks.

@nsheff nsheff changed the base branch from master to dev February 2, 2024 18:30
@khoroshevskyi khoroshevskyi self-requested a review February 4, 2024 19:28
Copy link
Member

@khoroshevskyi khoroshevskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! The changes look good to me. I will merge it to the dev branch, make a few other changes and release a new version tomorrow.

@khoroshevskyi khoroshevskyi merged commit afa41bb into pepkit:dev Feb 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants