Skip to content

Commit

Permalink
Fix bug with compute resource variable
Browse files Browse the repository at this point in the history
  • Loading branch information
@nsheff
nsheff committed Apr 23, 2019
1 parent b13224b commit 48cb76e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion looper/pipeline_interface.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from .utils import get_logger
from attmap import PathExAttMap
from peppy import utils, Sample
from peppy.const import DEFAULT_COMPUTE_RESOURCES_NAME
from divvy import DEFAULT_COMPUTE_RESOURCES_NAME
from peppy.utils import is_command_callable


Expand Down

4 comments on commit 48cb76e

@nsheff
Copy link
Contributor Author

@nsheff nsheff commented on 48cb76e Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this commit is causing failure on travis;

https://travis-ci.org/pepkit/looper/builds/523689301?utm_source=github_status&utm_medium=notification

But in the other way gave me errors. I don't see how this could have worked unless this was removed from peppy on dev or something...

@nsheff
Copy link
Contributor Author

@nsheff nsheff commented on 48cb76e Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this was another commit I thought I was putting on dev, whoops).

@nsheff
Copy link
Contributor Author

@nsheff nsheff commented on 48cb76e Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks like this is traced to here: pepkit/peppy@4939659

my bad. sorry to cause this. hmmm... @vreuter if we just need to add divvy to the requirements-dev.txt or requirements-test.txt file would that solve it? that variable is in divvy but it looks like it's just not getting installed by travis...

@vreuter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry, I cleared out some duplicate declarations recently so that for more variables there's a single import source / point of truth, and updated requirements accordingly. I think I made peppy and looper depend on divvy v0.4dev, so the builds can't find it. There may be a way to have Travis use unreleased versions of dependencies, but I've never done that so am not familiar. It feels like high-demand enough that it seems likely to me. I can look into it if you want, or we could do another small release for divvy soon.

Please sign in to comment.