Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set index if specified in output schema #141

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

donaldcampbelljr
Copy link
Contributor

Closes #105

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0ea22d4) 62.73% compared to head (9bf6bca) 62.69%.

Files Patch % Lines
pipestat/backends/db_backend/db_parsed_schema.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #141      +/-   ##
==========================================
- Coverage   62.73%   62.69%   -0.04%     
==========================================
  Files          15       15              
  Lines        2321     2327       +6     
==========================================
+ Hits         1456     1459       +3     
- Misses        865      868       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khoroshevskyi khoroshevskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you please add docs about indexing

@donaldcampbelljr
Copy link
Contributor Author

Great. I've added the requested docs.

@donaldcampbelljr donaldcampbelljr merged commit b971107 into dev Jan 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants