EVEREST-1819 [CLI] Get rid of spf13/viper lib for parsing CLI params #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxkondr
commented
Jan 16, 2025
•
maxkondr
commented
- Use spf13/cobra lib only for parsing CLI params
- Parse global flags (--verbose, --json, --kubeconfig) on root level
- Extend examples
- Use approach for commands initialisation suggested by cobra lib
- Use spf13/cobra lib only for parsing CLI params - Parse global flags (--verbose, --json, --kubeconfig) on root level - Extend examples
mayankshah1607
approved these changes
Jan 17, 2025
maxkondr
force-pushed
the
EVEREST-1819-main-remove-viper
branch
from
b5fa314 to
a81d8f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.