Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVEREST-1799 get groups claim and validate permissions #980

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

recharte
Copy link
Collaborator

@recharte recharte commented Jan 3, 2025

EVEREST-1799
FB

Summary

This pull request implements support for validating RBAC permissions against user groups fetched from an external IDP. The changes address challenges with the current "sub"-based permissions validation by introducing group-based RBAC, as described in EVEREST-1799

Key Changes

OIDC Integration:

  • Updated the OIDC flow to request the groups scope during authentication.
  • Extracted the groups claim from the ID token if it is returned by the IDP.

RBAC Evaluation Logic:

  • Extended the RBAC validation logic to check permissions against:
    • The user's sub ID.
    • Any groups the user belongs to (based on the groups claim).

@recharte recharte force-pushed the EVEREST-1799-rbac-groups-claim branch 2 times, most recently from b6c1036 to c465381 Compare January 3, 2025 14:54
@recharte recharte marked this pull request as ready for review January 3, 2025 14:55
@recharte recharte requested review from a team as code owners January 3, 2025 14:55
Base automatically changed from EVEREST-107-api-refactoring to main January 8, 2025 06:40
@recharte recharte force-pushed the EVEREST-1799-rbac-groups-claim branch from c465381 to 6253422 Compare January 9, 2025 10:27
@recharte recharte force-pushed the EVEREST-1799-rbac-groups-claim branch from 6253422 to 20e3b7e Compare January 9, 2025 16:47
@recharte recharte force-pushed the EVEREST-1799-rbac-groups-claim branch from 20e3b7e to 30c9a3b Compare January 9, 2025 16:52
@recharte recharte force-pushed the EVEREST-1799-rbac-groups-claim branch from 30c9a3b to 39f2145 Compare January 13, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants