Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12344 Clear state before querying details #1532

Merged
merged 2 commits into from
Aug 16, 2023
Merged

PMM-12344 Clear state before querying details #1532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33b1eb6
PMM-12344 Clear state before querying details
matejkubinec Jul 24, 2023
a487fba
Merge branch 'main' of https://github.com/percona/grafana-dashboards …
matejkubinec Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions pmm-app/src/pmm-qan/panel/components/Details/Details.hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,31 @@
import { useContext, useEffect, useState } from 'react';
import { QueryAnalyticsProvider } from 'pmm-qan/panel/provider/provider';
import { Databases } from 'shared/core';
import DetailsService from './Details.service';
import { DatabasesType, QueryExampleResponseItem } from './Details.types';

export const useDetails = (): [boolean, QueryExampleResponseItem[], DatabasesType] => {
const {
panelState: {
queryId, groupBy, from, to, labels,
queryId,
groupBy,
from,
to,
labels,
},
} = useContext(QueryAnalyticsProvider);
const [loading, setLoading] = useState<boolean>(false);
const [examples, setExamples] = useState<QueryExampleResponseItem[]>([]);
const [databaseType, setDatabaseType] = useState<DatabasesType>(Databases.mysql);
const [databaseType, setDatabaseType] = useState<DatabasesType>();

useEffect(() => {
(async () => {
try {
setLoading(true);
// clear state so we don't get
// invalid data in between query changes
setExamples([]);
setDatabaseType(undefined);

const result = await DetailsService.getExample({
filterBy: queryId,
groupBy,
Expand All @@ -29,8 +37,10 @@ export const useDetails = (): [boolean, QueryExampleResponseItem[], DatabasesTyp
const examples = result.query_examples;
const databaseType = result.query_examples[0].service_type;

setExamples(examples);
// clear database type first
// won't be an issue once we upgrade to React 18 (batched updates)
setDatabaseType(databaseType);
setExamples(examples);
} catch (e) {
console.error(e);
} finally {
Expand Down