Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12284 remove Alertmanager datasource #1546

Merged
merged 5 commits into from
Dec 6, 2023
Merged

PMM-12284 remove Alertmanager datasource #1546

merged 5 commits into from
Dec 6, 2023

Conversation

ademidoff
Copy link
Member

No description provided.

@matejkubinec matejkubinec self-requested a review December 6, 2023 10:33
matejkubinec
matejkubinec reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@matejkubinec matejkubinec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ademidoff

Could you check misc/convert-dash-to-PMM.py there seems to be a mention of the datasource.

@ademidoff ademidoff merged commit d06d115 into v3 Dec 6, 2023
7 checks passed
@ademidoff ademidoff deleted the PMM-12284-remove-alermanager-datasource branch December 6, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejkubinec matejkubinec matejkubinec approved these changes

@YashSartanpara1 YashSartanpara1 Awaiting requested review from YashSartanpara1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ademidoff @matejkubinec