-
Notifications
You must be signed in to change notification settings - Fork 25
K8SPXC-1470 Updated proxy pages with the information about migration from one to another #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…from one to another
modified: docs/haproxy-conf.md
new file: docs/load-balancing.md
modified: docs/proxysql-conf.md
modified: mkdocs-base.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive documentation about load balancing options and proxy migration capabilities in the Percona Operator for MySQL. It introduces a new overview page explaining the differences between HAProxy and ProxySQL, and documents the process for switching between proxies.
- Added new
load-balancing.mdoverview page with proxy comparison and use cases - Created
proxy-switching.mdwith migration procedures between HAProxy and ProxySQL - Updated HAProxy and ProxySQL configuration pages to remove outdated warnings and add cross-references
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/load-balancing.md | New overview page comparing HAProxy and ProxySQL with use cases and recommendations |
| proxy-switching.md | New guide documenting how to switch between proxies with kubectl commands |
| docs/proxysql-conf.md | Removed outdated warning about proxy switching limitations and added reference to new load balancing overview |
| docs/haproxy-conf.md | Removed duplicate proxy selection information and added reference to new load balancing overview |
| mkdocs-base.yml | Restructured navigation to group load balancing pages under a new section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - "Overview": load-balancing.md | ||
| - "HAProxy": haproxy-conf.md | ||
| - "ProxySQL": proxysql-conf.md | ||
| - proxy-switching.md |
Copilot
AI
Dec 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The navigation entry for proxy-switching.md should include a title. Consider adding a title like 'Switching proxies' to maintain consistency with other navigation items in the section.
| - proxy-switching.md | |
| - "Switching proxies": proxy-switching.md |
proxy-switching.md
Outdated
|
|
||
| !!! warning | ||
|
|
||
| Switching from ProxySQL to HAProxy will cause Percona XtraDB Cluster Pods to restart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not true, PXC pods won't be restarted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, updated.
53ccf1e to
b1da551
Compare
bc62b83 to
aa8715c
Compare
aa8715c to
81e107f
Compare
modified: docs/haproxy-conf.md
new file: docs/load-balancing.md
modified: docs/proxysql-conf.md
modified: mkdocs-base.yml