Skip to content

Fix: downtime registration without duration now sets default value and updated docs too #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: downtime registration without duration now sets default value and updated docs too #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/deployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ Shown above are uses for both `orchestrator-client` and the `orchestrator` comma
```shell
$ curl -s "http://my.orchestrator.service:80/api/begin-downtime/my.hostname/3306/wallace/experimenting+failover/45m"
```
`45m` is duration of time in minutes the host will be marked under downtime.
If we don't mention the time, it would consider `config.MaintenanceExpireMinutes` time as downtime which is default 10m

The `orchestrator-client` script runs this very API call, wrapping it up and encoding the URL path. It can also automatically detect the leader, in case you don't want to run through a proxy.

Expand Down
5 changes: 5 additions & 0 deletions go/inst/downtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ package inst

import (
"time"
"github.com/openark/orchestrator/go/config"
)


type Downtime struct {
Key *InstanceKey
Owner string
Expand All @@ -32,6 +34,9 @@ type Downtime struct {
}

func NewDowntime(instanceKey *InstanceKey, owner string, reason string, duration time.Duration) *Downtime {
if duration == 0 {
duration = config.MaintenanceExpireMinutes * time.Minute
}
downtime := &Downtime{
Key: instanceKey,
Owner: owner,
Expand Down