Fix replica tracking and undefined DSN value warnings in pt-online-schema-change #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-schema-change Avoids "Use of uninitialized value in string eq" warnings in ReplicaLagWaiter by safely handling undefined DSN host/port values. This change uses the defined-or operator (// '') to ensure comparisons work even when DSN fields are not initialized, preventing unnecessary reconnections to replicas.
|
|
zxzharmlesszxz
changed the title
|
without this changes replica lag working only when servers on host table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-schema-change
Avoids "Use of uninitialized value in string eq" warnings in ReplicaLagWaiter by safely handling undefined DSN host/port values. This change uses the defined-or operator (// '') to ensure comparisons work even when DSN fields are not initialized, preventing unnecessary reconnections to replicas.