This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
PMM-9630 Use status, status_code only for some versions. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -259,7 +250,7 @@ func (v *pgStatMonitorAllViewType) NewStruct() reform.Struct { | |||
|
|
|||
| // String returns a string representation of this struct or record. | |||
| func (s pgStatMonitor) String() string { | |||
| res := make([]string, 51) | |||
| res := make([]string, 49) | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
mnd: Magic number: 49, in detected (gomnd)
|
2 failed tests are not related to PR. See empty PR failed on same tests here: #328 |
This reverts commit 22ece8f.
percona-csalguero
approved these changes
Mar 9, 2022
ShashankSinha252
approved these changes
Mar 11, 2022
1 task
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PMM-9630
Build: SUBMODULES-0