Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13315 Service account max length. #3221

Open
wants to merge 18 commits into
base: v3
Choose a base branch
from

Conversation

JiriCtvrtka
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka commented Oct 1, 2024

@JiriCtvrtka JiriCtvrtka changed the title Pmm 13315 service account max length PMM-13315 Service account max length. Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.42%. Comparing base (6a67936) to head (61e0c7d).

Files with missing lines Patch % Lines
managed/services/grafana/client.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3221      +/-   ##
==========================================
- Coverage   43.45%   43.42%   -0.03%     
==========================================
  Files         360      360              
  Lines       43947    43947              
==========================================
- Hits        19095    19084      -11     
- Misses      23193    23203      +10     
- Partials     1659     1660       +1     
Flag Coverage Δ
admin 11.49% <ø> (ø)
agent 51.80% <ø> (-0.13%) ⬇️
managed 45.17% <66.66%> (+0.01%) ⬆️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review October 3, 2024 11:18
@JiriCtvrtka JiriCtvrtka requested a review from a team as a code owner October 3, 2024 11:18
@JiriCtvrtka JiriCtvrtka requested review from BupycHuk, idoqo and ademidoff and removed request for a team October 3, 2024 11:18
api-tests/server/auth_test.go Outdated Show resolved Hide resolved
managed/services/grafana/client.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants