Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13416 Fix enum flags in pmm-admin. #3236

Open
wants to merge 7 commits into
base: v3
Choose a base branch
from

Conversation

BupycHuk
Copy link
Member

PMM-13416

Link to the Feature Build: SUBMODULES-3737

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested a review from a team as a code owner October 13, 2024 09:50
@BupycHuk BupycHuk requested review from idoqo and JiriCtvrtka and removed request for a team October 13, 2024 09:50
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 2.50000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 43.45%. Comparing base (50d1e9a) to head (e4f8742).

Files with missing lines Patch % Lines
admin/pkg/flags/loglevel.go 0.00% 4 Missing ⚠️
admin/commands/management/add_mysql.go 0.00% 3 Missing ⚠️
admin/commands/management/add_postgresql.go 0.00% 3 Missing ⚠️
.../inventory/add_agent_qan_mysql_perfschema_agent.go 0.00% 2 Missing ⚠️
...nds/inventory/add_agent_qan_mysql_slowlog_agent.go 0.00% 2 Missing ⚠️
...ntory/add_agent_qan_postgres_pgstatements_agent.go 0.00% 2 Missing ⚠️
...tory/add_agent_qan_postgres_pgstatmonitor_agent.go 0.00% 2 Missing ⚠️
admin/commands/management/add_mongodb.go 0.00% 2 Missing ⚠️
admin/commands/management/add_proxysql.go 0.00% 2 Missing ⚠️
admin/pkg/flags/comments_parsing.go 0.00% 2 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3236      +/-   ##
==========================================
- Coverage   43.45%   43.45%   -0.01%     
==========================================
  Files         360      363       +3     
  Lines       43977    43934      -43     
==========================================
- Hits        19112    19090      -22     
+ Misses      23204    23182      -22     
- Partials     1661     1662       +1     
Flag Coverage Δ
admin 11.53% <2.70%> (+0.04%) ⬆️
agent 51.93% <0.00%> (ø)
managed 45.16% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants