PMM-12641 Optimize PMM build scripts

[ademidoff]

PMM-12641

Link to the Feature Build: SUBMODULES-3739

To the reviewer
This PR is another iteration on this ticket, so it's probably not the final one. However, the number of changes is significant, so I prefer to submit it for review now.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.42%. Comparing base (50d1e9a) to head (8fd8ce5).

Additional details and impacted files

@@            Coverage Diff             @@
##               v3    #3239      +/-   ##
==========================================
- Coverage   43.45%   43.42%   -0.04%     
==========================================
  Files         360      360              
  Lines       43977    43977              
==========================================
- Hits        19112    19098      -14     
- Misses      23204    23218      +14     
  Partials     1661     1661              

Flag	Coverage Δ
admin	11.49% <ø> (ø)
agent	51.80% <ø> (-0.13%)	⬇️
managed	45.17% <ø> (ø)
vmproxy	68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[catalinaadam]

suggested more descriptive names

[BupycHuk]

Are you sure that we don't need it anymore? I remember there were issue with PostgreSQL. I hope it won't affect upgrade from PMM 2 to PMM 3.

[ademidoff]

Yes, pretty sure. From the logs, the OS emits a good number of warnings not being able to apply just LC_ALL. However, once the language package is installed, we see that the default OS language settings are set, as expected, to en_US.utf8. Therefore, this removal fixes the the warnings related to things that don't work anyway.

To give us a bit more comfort going forward with this removal, this is what the output of locale currently looks like (i.e. before this removal):

LANG=en_US.utf8
LC_CTYPE="en_US.utf8"
LC_NUMERIC="en_US.utf8"
LC_TIME="en_US.utf8"
LC_COLLATE="en_US.utf8"
LC_MONETARY="en_US.utf8"
LC_MESSAGES="en_US.utf8"
LC_PAPER="en_US.utf8"
LC_NAME="en_US.utf8"
LC_ADDRESS="en_US.utf8"
LC_TELEPHONE="en_US.utf8"
LC_MEASUREMENT="en_US.utf8"
LC_IDENTIFICATION="en_US.utf8"
LC_ALL=

As you can see, LC_ALL is empty for the reason mentioned above. Thus, it's no harm.