Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13399 include nomad into pmm client #3257

Open
wants to merge 16 commits into
base: v3
Choose a base branch
from

Conversation

BupycHuk
Copy link
Member

@BupycHuk BupycHuk commented Oct 19, 2024

PMM-13399

Link to the Feature Build: SUBMODULES-3740

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 43.43%. Comparing base (6a67936) to head (44efb08).
Report is 2 commits behind head on v3.

Files with missing lines Patch % Lines
agent/agents/supervisor/supervisor.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3257      +/-   ##
==========================================
- Coverage   43.45%   43.43%   -0.03%     
==========================================
  Files         360      360              
  Lines       43947    43988      +41     
==========================================
+ Hits        19095    19104       +9     
- Misses      23193    23222      +29     
- Partials     1659     1662       +3     
Flag Coverage Δ
admin 11.49% <ø> (ø)
agent 51.83% <88.23%> (-0.11%) ⬇️
managed 45.16% <ø> (+<0.01%) ⬆️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BupycHuk BupycHuk marked this pull request as ready for review October 21, 2024 09:40
@BupycHuk BupycHuk requested a review from a team as a code owner October 21, 2024 09:40
@BupycHuk BupycHuk requested review from idoqo, JiriCtvrtka and ademidoff and removed request for a team October 21, 2024 09:40
agent/config/config.go Outdated Show resolved Hide resolved
agent/config/config.go Outdated Show resolved Hide resolved
agent/config/config.go Outdated Show resolved Hide resolved
build/scripts/build-client-source Outdated Show resolved Hide resolved
build/scripts/install_tarball Outdated Show resolved Hide resolved
BupycHuk and others added 2 commits October 21, 2024 22:31
Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants