PoA support for selenium 4 without desired capibilites #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chinmay-browserstack
commented
Oct 14, 2024
•
chinmay-browserstack
commented
- Fix for PoA with selenium version > 4.9 throwing error because desired capabilities property is deprecated from selenium
ninadbstack
reviewed
Oct 15, 2024
percy/driver_metadata.py
Outdated
| try: | ||
| session_caps = dict(self.driver.desired_capabilities) | ||
| except Exception: | ||
| session_caps = {} |
There was a problem hiding this comment.
what all do we need from session caps ? if we are using nothing then why were we reading it in the first place ?
There was a problem hiding this comment.
actually we don't need session caps so removing it. anyways in current flow also we have spelling mistake due to which session caps are passed but not used in cli
ninadbstack
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.