Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ uncache stories before extracting them #828

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

nilshah98
Copy link
Contributor

No description provided.

@itsjwala itsjwala added the ✨ enhancement New feature or request label Oct 18, 2023
@nilshah98 nilshah98 changed the title feat: uncache stories before extracting them ✨ uncache stories before extracting them Oct 18, 2023
@nilshah98 nilshah98 changed the base branch from master to add-storybookv7-support October 18, 2023 16:02
@nilshah98 nilshah98 marked this pull request as ready for review October 18, 2023 16:02
@nilshah98 nilshah98 requested a review from a team as a code owner October 18, 2023 16:02
@nilshah98 nilshah98 requested review from itsjwala and pankaj443 and removed request for a team October 18, 2023 16:02
@nilshah98 nilshah98 merged commit d24e398 into add-storybookv7-support Oct 18, 2023
4 checks passed
@nilshah98 nilshah98 deleted the fix-evalStorybookStorySnapshots branch October 18, 2023 16:03
nilshah98 added a commit that referenced this pull request Oct 27, 2023
* feat: uncache stories before extracting them (#828)

* ✨ add fetching env support for storybook v7+ (#827)

* feat: add fetching env support for storybook v7+

* chore: lint using --fix

* fix: evalStorybookEnvironmentInfo

* feat: update package.json and lockfile for storybook v7

* fix: convert start-storybook to storybook dev

* fix: add framework option to storybook config

* feat: update babel and package config to node 16

* feat: update github actions to use node 16

* chore: lint fix

* feat: add storybook-v6 to support start-storybook and build-storybook binaries

* wip: use storybook 6 as default

* fix: make storybook6 default, and keep storybook7 separate

* fix: inherit stdio to run tests

* fix: support storybook6 tests

* wip: add flag support for switching between storybook v6 <> v7 tests

* fix: build storybook command in pretest

* wip: add utils and support for storybook v7 tests only

* test: fix case where storybook had not loaded yet for live url testing

* wip: run storybook6 tests by default

* fix: change babel build target version to 14

* feat: add storybook v6 and v7 test workflows, also remove default test workflow

* feat: downgrade node 16 to node 14 in github workflows and package json engine

* feat: upgrade node 14 to 16 for lint and release workflows, since they run yarn in their workflows

* chore: update yarn.lock as per storybook v7, node 16

* fix: pin action sha, use inputs.branch and use yarn test in v6

* fix: check if error exists before checking for message attribute

* docs: add and update `Development` section in readme

* chore: add EOF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants