feat: added defer uploads for percy-storybook #847
Conversation
src/snapshots.js
Outdated
| options.domSnapshot = domSnapshot; | ||
| // validate without logging to prune all other options | ||
| PercyConfig.validate(options, '/snapshot/dom'); | ||
| // validate without logging to prune all other options |
src/snapshots.js
Outdated
| } else { | ||
| log.debug(`Loading story: ${options.name}`); | ||
| // when not dry-running and javascript is not enabled, capture the story dom | ||
| yield page.eval(evalSetCurrentStory, { id, args, globals, queryParams }); | ||
| /* istanbul ignore next: tested, but coverage is stripped */ | ||
| let { dom, domSnapshot = dom } = yield page.snapshot(options); | ||
| options.domSnapshot = domSnapshot; | ||
| for (let i = 0; i < percy.config.snapshot.widths.length; i++) { |
There was a problem hiding this comment.
This will increase User's CI time considerably, we've seen few customers using on packed CI with multiple widhts.
we should ideally ship this behind feature, or have it as accepted bug.
There was a problem hiding this comment.
There are also issues with logging, we are only doing an alpha release for testing it with client tentatively and we will need to fix some things [ logging, multiple widths etc ] before we can add this to stable
There was a problem hiding this comment.
done, we will rely on the customer's percy config to provide defer-uploads
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR was closed because it has been stalled for 28 days with no activity. |
Context-
defer-uploadsis used for capturing multiple dom snapshots, for same webpage.defer-uploadsconfigdefer-uploadsconfig, and then takes multiple snapshots for same webpage depending on number of widthsWhy test cases have changes so much ?
1.24.0defer-uploadsconfig was not passed successfully from cli -> storybook due to configSchema being outdated in1.24.0cli-commandpackage to1.27.4which fixed this issue anddefer-uploadstests started working.1.27.4we also updated the createTestServer mock service with this particular PR./iframe.htmland/iframe.html?id=1as different requests and responds to them differently.iframe.htmlget all stories and then navigate toiframe.html?id={storyId}which is not available anymore.iframe.htmlandiframe.html?id={storyId}&viewMode=storyroute.Related PRs-