Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making storybook addons integration #912

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

prklm10
Copy link
Contributor

@prklm10 prklm10 commented Mar 26, 2024

Making storybook integration
Readme Update
Screenshot 2024-03-26 at 5 15 33 PM

@prklm10 prklm10 requested a review from a team as a code owner March 26, 2024 11:37
README.md Outdated

Percy compares new snapshots against relevant baselines to detect visual changes. Percy manages baseline picking across branches so your tests are always relevant. If visual changes are detected, Percy highlights and groups the resulting diffs for you to review.

# Run your first build with percy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integrate your Storybook tests with Percy
Before integration, you can explore [Percy’s sample build tutorial for Storybook.](https://www.browserstack.com/docs/percy/sample-build/storybook)
Integrate your Storybook automated tests with BrowserStack Percy
 and here's an overview of the integration steps:

Change this to above as this seems to refer to steps so Integrate your Storybook tests with Percy will become a h2 header and installations etc will become h3 and part of h2. Which will require more changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, also we should make it h2 anyway, same size as How does Percy work?

Copy link

@KhushbuRander KhushbuRander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prklm10 prklm10 merged commit 7933f55 into master Mar 26, 2024
5 checks passed
@prklm10 prklm10 deleted the PER-9999_making_storybook_integration branch March 26, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants