Add Storybook 8 compatibility #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaelFr Thanks for debugging the issue and for initial PR. As this will need full scale support and testing before we can merge it, I will recommend you to create a support ticket with Browserstack and we would pick this accordingly! |
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR was closed because it has been stalled for 28 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I faced this issue, which seems to be related to this part of the migration.
I made this change and tried it locally. It worked.
It should be better to add the dependabot PR to upgrade to Storybook 8, but the node version in tests should be changed to 18+.
Additionnaly, I was unable to run the tests due to download failure (maybe related to my company's security policy) :
There are definitely a lot more things that need to change to fully handle v8, but this seems like a good start.