Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inky/impression: embed Dev #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Mar 18, 2025

Minor refactor to embed Dev directly into DevImpression instead of via a pointer.

Cc: @fstanis @gsexton

Minor refactor to embed Dev directly instead of via a pointer.
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.3%. Comparing base (bc9678a) to head (c176b52).

Files with missing lines Patch % Lines
inky/impression.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #103   +/-   ##
=====================================
  Coverage   52.3%   52.3%           
=====================================
  Files        109     109           
  Lines      13864   13864           
=====================================
  Hits        7247    7247           
  Misses      6296    6296           
  Partials     321     321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gsexton gsexton self-requested a review March 20, 2025 00:27
Copy link
Contributor

@gsexton gsexton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@gsexton
Copy link
Contributor

gsexton commented Mar 20, 2025

@dolmen I've resolved the issue with the cmd repo. The PR looks ok. If you can't merge with the diff coverage I can do it.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less pointers is always good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants