-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allwinner: Added support for allwinner H616 processor #58
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution!
I see a few failures unrelated to your change on the CI, I'll take a look to try to fix these. The PR will fail for the license header check at least, so you'll want to fix that.
A few changes requested, nothing significant.
I fixed the checks on origin/main, can you rebase and push again? Thanks! |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you figure out why the checks still fail? Do you want help with diagnosing the problem?
Added support for the allwinner H616 processor. Apparently, this also works for H618 processor.
5da71bd
to
4abefc9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
+ Coverage 27.4% 28.2% +0.8%
=======================================
Files 89 91 +2
Lines 11011 8915 -2096
=======================================
- Hits 3014 2511 -503
+ Misses 7864 6263 -1601
- Partials 133 141 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks again!
There's a test failure to fix on Windows and then it's good to go.
@didiercrunch Thanks for this. I was working on creating an orange pi variation for H616, and I just found your PR. I'm working on an Orange Pi Zero 2W, and your work may help me (at least to figure what else I should fix) |
Added support for the allwinner H616 processor. Apparently, this also works for H618 processor.
Helps with #57 but doesn't not completely fix it.