Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XcodeProj minimal version #762

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

dazy1030
Copy link
Contributor

@dazy1030 dazy1030 commented Jun 29, 2024

If you follow the contents of Package.swift, the version of XcodeProj may be less than 8.16.0 depending on the environment in which Periphery is installed. However, the XcodeProject class uses the localPackages property introduced after 8.16.0 of XcodeProj, resulting in a build error.
This Pull Request updates the minimum version of XcodeProj so that this error does not occur.

One concern is that the version of XcodeProj on which XcodeGen depends is fixed at 8.13.0. Projects that use it at the same time are more likely to fail to resolve dependencies.

for localPackage in xcodeProject.pbxproj.rootObject?.localPackages ?? [] {

https://github.com/tuist/XcodeProj/blob/447c159b0c5fb047a024fd8d942d4a76cf47dde0/Sources/XcodeProj/Objects/Project/PBXProject.swift#L155

@ileitch ileitch merged commit a67bff1 into peripheryapp:master Jun 30, 2024
4 checks passed
@dazy1030
Copy link
Contributor Author

One concern is that the version of XcodeProj on which XcodeGen depends is fixed at 8.13.0. Projects that use it at the same time are more likely to fail to resolve dependencies.

This issue has been resolved in XcodeGen version 2.41.0 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants