Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for permit API CLI wrapper #65

Merged
merged 16 commits into from
Mar 10, 2025
Merged

Initial commit for permit API CLI wrapper #65

merged 16 commits into from
Mar 10, 2025

Conversation

orweis
Copy link
Collaborator

@orweis orweis commented Feb 24, 2025

No description provided.

Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
@orweis orweis requested a review from gemanor February 24, 2025 09:43
Copy link
Collaborator

@gemanor gemanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, will expand in Slack

orweis added 8 commits March 3, 2025 10:41
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Signed-off-by: orweis <orweis@gmail.com>
Copy link
Collaborator

@gemanor gemanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, mostly about convention.

@orweis orweis merged commit 66a1dca into main Mar 10, 2025
3 checks passed
@orweis orweis deleted the users-api branch March 10, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants