Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing relationship tuple filters to the rel tuples api #102

Merged

Conversation

asafc
Copy link
Contributor

@asafc asafc commented Aug 26, 2024

No description provided.

Copy link
Contributor

@maya-barak maya-barak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- Added one comment

@asafc
Copy link
Contributor Author

asafc commented Aug 26, 2024

e2e test is flaky, unrelated to PR, merging.

@asafc asafc merged commit c45b91d into main Aug 26, 2024
3 of 4 checks passed
Comment on lines +47 to +50
subject_key: Optional[str] = None,
relation_key: Optional[str] = None,
object_key: Optional[str] = None,
tenant_key: Optional[str] = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put those variables last, if someone uses this function like this : permit.api.relationship_tuples.list(2,100) than your changes will break it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants