Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python SDK Function for PDP List Role Assignments #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maya-barak
Copy link
Contributor

No description provided.

params.update(dict(user=user))
if role is not None:
params.update(dict(role=role))
if tenant is not None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing resource condition

Comment on lines +68 to +69
class SyncEnforcer(PdpApi, metaclass=SyncClass):
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

resource_instance: Optional[str] = None,
page: int = 1,
per_page: int = 100,
) -> dict:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No schema ?


Usage example:

permit = Permit(token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing rest of the line

@@ -15,6 +15,7 @@ def print_break():


async def test_permission_check_e2e(permit: Permit):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@@ -191,7 +192,7 @@ async def test_permission_check_e2e(permit: Permit):

logger.info("testing bulk permission check")
assert (
await permit.bulk_check(
await permit.pdp_api.list_role_assignment(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing this

Copy link
Contributor

@RazcoDev RazcoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some major comments - also, no interfaces ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants