-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python SDK Function for PDP List Role Assignments #64
base: main
Are you sure you want to change the base?
Python SDK Function for PDP List Role Assignments #64
Conversation
params.update(dict(user=user)) | ||
if role is not None: | ||
params.update(dict(role=role)) | ||
if tenant is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing resource condition
class SyncEnforcer(PdpApi, metaclass=SyncClass): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
resource_instance: Optional[str] = None, | ||
page: int = 1, | ||
per_page: int = 100, | ||
) -> dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No schema ?
|
||
Usage example: | ||
|
||
permit = Permit(token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing rest of the line
@@ -15,6 +15,7 @@ def print_break(): | |||
|
|||
|
|||
async def test_permission_check_e2e(permit: Permit): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
@@ -191,7 +192,7 @@ async def test_permission_check_e2e(permit: Permit): | |||
|
|||
logger.info("testing bulk permission check") | |||
assert ( | |||
await permit.bulk_check( | |||
await permit.pdp_api.list_role_assignment( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why changing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some major comments - also, no interfaces ?
No description provided.