Standardize container name and type validation #2379
Conversation
fflaten
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -306,7 +275,7 @@ | |||
| function Write-PesterReport { | |||
| param ( | |||
| [Parameter(mandatory = $true, valueFromPipeline = $true)] | |||
| $RunResult | |||
| [Pester.Run] $RunResult | |||
Check warning
Code scanning / PSScriptAnalyzer
Command accepts pipeline input but has not defined a process block. Warning
| @@ -85,7 +85,7 @@ | |||
| #> | |||
| param ( | |||
| [parameter(Mandatory = $true, ValueFromPipeline = $true)] | |||
| $Result, | |||
| [Pester.Run] $Result, | |||
Check warning
Code scanning / PSScriptAnalyzer
Command accepts pipeline input but has not defined a process block. Warning
| @@ -135,7 +135,7 @@ | |||
| #> | |||
| param ( | |||
| [parameter(Mandatory = $true, ValueFromPipeline = $true)] | |||
| $Result, | |||
| [Pester.Run] $Result, | |||
Check warning
Code scanning / PSScriptAnalyzer
Command accepts pipeline input but has not defined a process block. Warning
| @@ -147,7 +147,7 @@ | |||
| function Export-XmlReport { | |||
| param ( | |||
| [parameter(Mandatory = $true, ValueFromPipeline = $true)] | |||
| $Result, | |||
| [Pester.Run] $Result, | |||
Check warning
Code scanning / PSScriptAnalyzer
Command accepts pipeline input but has not defined a process block. Warning
| @@ -272,7 +272,7 @@ | |||
| #> | |||
| param ( | |||
| [parameter(Mandatory = $true, ValueFromPipeline = $true)] | |||
| $Result, | |||
| [Pester.Run] $Result, | |||
Check warning
Code scanning / PSScriptAnalyzer
Command accepts pipeline input but has not defined a process block. Warning
| @@ -362,7 +362,7 @@ | |||
| #> | |||
| param ( | |||
| [parameter(Mandatory = $true, ValueFromPipeline = $true)] | |||
| $Result, | |||
| [Pester.Run] $Result, | |||
Check warning
Code scanning / PSScriptAnalyzer
Command accepts pipeline input but has not defined a process block. Warning
|
As always, thank you. |
PR Summary
This PR adds a
Name-property to Container-objects to standardize naming currently set in multiple places.There was two variations in the codebase when container type was
File:$Item.ToString()which is FullName in PS7, but Name in Windows PowerShell$Item.FullNameAfter PR: Prefer
FullNameifFileInfo-object for consistency, elseToString().There was two variations in the codebase when the scriptblock was linked to a file:
<ScriptBlock>file:line<ScriptBlock>:file:lineAfter PR:
<ScriptBlock>:file:linePR also moves container type validation to property setter to avoid checking in multiple places.
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.