-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PesterTests and devcontainer to .NET 8 #2430
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5d08590
Update devcontainer to .NET 8 SDK
fflaten 5c7c219
Add extensions for CI to devcontainer
fflaten 34810cf
Update contributing guide
fflaten d4d133f
Update PesterTests to .NET 8
fflaten e805e2c
Ignore build warning for vulnerable PowerShell 6.0.4 SDK
fflaten 2efc4c2
Merge branch 'main' into dotnet8-sdk
nohwnd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,25 @@ | ||
| // For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at: | ||
| // https://github.com/microsoft/vscode-dev-containers/tree/v0.209.5/containers/dotnet | ||
| // For format details, see https://aka.ms/vscode-remote/devcontainer.json | ||
| { | ||
| "name": "Pester", | ||
| "build": { | ||
| "dockerfile": "Dockerfile", | ||
| "args": { | ||
| // Update 'VARIANT' to pick a .NET Core version: 3.1, 5.0, 6.0 | ||
| // Append -bullseye or -focal to pin to an OS version. Using focal (Ubuntu) for pwsh support | ||
| "VARIANT": "6.0-focal" | ||
| "image": "mcr.microsoft.com/devcontainers/dotnet:1-8.0-jammy", | ||
| "remoteUser": "vscode", | ||
| "customizations": { | ||
| "codespaces": { | ||
| "openFiles": [ | ||
| "CONTRIBUTING.md" | ||
| ] | ||
| }, | ||
| "vscode": { | ||
| "settings": {}, | ||
| "extensions": [ | ||
| "ms-vscode.powershell", | ||
| "ms-dotnettools.csharp", | ||
| "redhat.vscode-xml", | ||
| "ms-azure-devops.azure-pipelines", | ||
| "GitHub.vscode-github-actions" | ||
| ] | ||
| } | ||
| }, | ||
| // Set *default* container specific settings.json values on container create. | ||
| "settings": {}, | ||
| // Add the IDs of extensions you want installed when the container is created. | ||
| "extensions": [ | ||
| "ms-vscode.powershell", | ||
| "ms-dotnettools.csharp", | ||
| "redhat.vscode-xml" | ||
| ], | ||
| // Use 'postCreateCommand' to run commands after the container is created. | ||
| // Restoring the c# projects | ||
| "postCreateCommand": "dotnet restore src/csharp" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the .NET Framework 4.5 Developer Pack necessary now that we use
Microsoft.NETFramework.ReferenceAssembliespackage? Haven't tested building on Windows in a while.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not (I have all of them installed so I cannot easily check), but the whole point of that nuget is that you can build .NET Framework even on Linux where it cannot run (without mono).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot make suggestion that deletes it, please delete it.