Ignore excluded/skipped tests and unnecessary setup/teardown using SkipRemainingOnFailure #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflaten
changed the title
fflaten
changed the title
Skipped-property only exists on Test
fflaten
commented
May 9, 2024
nohwnd
reviewed
May 14, 2024
| @@ -29,41 +54,18 @@ function Get-SkipRemainingOnFailurePlugin { | |||
| $p.Start = { | |||
| param ($Context) | |||
|
|
|||
| # TODO: Use $Context.GlobalPluginData.SkipRemainingOnFailure.SkippedCount when exposed in $Context | |||
There was a problem hiding this comment.
Is this something you will address in this PR or there should be issue created for this?
There was a problem hiding this comment.
New issue. Didn't want to touch plugin interface as it wasn't critical.
I'm happy to provide a follow-up PR when name and steps (all?) are decided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
-Skipfrom being marked as skipped byRun.SkipRemainingOnFailureoption.BeforeAll/AfterAllFix #2440
Fix #2424
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.