Include more statements in code coverage #2554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflaten
commented
Aug 3, 2024
Comment on lines
293
to
301
| $predicate = { | ||
| $args[0] -is [System.Management.Automation.Language.DynamicKeywordStatementAst] -or | ||
| $args[0] -is [System.Management.Automation.Language.CommandBaseAst] | ||
| $args[0] -is [System.Management.Automation.Language.CommandBaseAst] -or | ||
| $args[0] -is [System.Management.Automation.Language.BreakStatementAst] -or | ||
| $args[0] -is [System.Management.Automation.Language.ContinueStatementAst] -or | ||
| $args[0] -is [System.Management.Automation.Language.ExitStatementAst] -or | ||
| $args[0] -is [System.Management.Automation.Language.ThrowStatementAst] | ||
| } |
There was a problem hiding this comment.
Only updated PSv5+ predicate as we might remove the redundant predicate for v6.
A potential backport would need to extend both predicates.
fflaten
force-pushed
the
cc-statements
branch
from
93c73fb
to
6286afa
Compare
nohwnd
reviewed
Nov 12, 2024
| @@ -110,6 +110,7 @@ function Write-NUnitTestSuiteElements { | |||
|
|
|||
| $suites = @( | |||
| # Tests only have GroupId if parameterized. All other tests are put in group with '' value | |||
| # PowerShell 6.1+ sorts by default in Group-Object. We need to sort for consistent output in Windows PowerShell | |||
There was a problem hiding this comment.
This says we sort but the code below does not use sort? Is this a mistake?
There was a problem hiding this comment.
Very likely. Good catch, will fix. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Extends code coverage to include
break,continue,exitandthrowstatements.returnis not included due to inconsistent behavior (thoughreturn 123is already covered as a command expression)Adds sort after
Group-Objectto save future headaches with inconsistent report/output order in Windows PowerShell vs PowerShell 6.1 which sorts by default.Fix #1465
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.