Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS image and PublishCodeCoverageResults task in CI #2573

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

fflaten
Copy link
Collaborator

@fflaten fflaten commented Nov 1, 2024

PR Summary

  • Replaces deprecated macOS 12 runner image with macOS 14,
  • Upgrades PublishCodeCoverageResults to v2 because v1 is deprecated. See warnings in recent CI runs.

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@fflaten
Copy link
Collaborator Author

fflaten commented Nov 1, 2024

Are we using rel/5.6.x or rel/5.x.x going forward for backports?

@fflaten
Copy link
Collaborator Author

fflaten commented Nov 2, 2024

The v2 publish CC task still has limited output compared to v1.

E.g. it doesn't support viewing files with highlighted lines, but with our single psm1 source file it's probably a tough render anyways, and it doesn't work in our current setup neither

Copy link
Contributor

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nohwnd nohwnd merged commit 32cfd48 into pester:main Nov 12, 2024
11 checks passed
@fflaten fflaten deleted the update-ci branch November 17, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants