fix: Incorrect exit code with --fail-on-incomplete#1348
Closed
mdeboer wants to merge 1 commit intopestphp:3.xfrom
Closed
fix: Incorrect exit code with --fail-on-incomplete#1348mdeboer wants to merge 1 commit intopestphp:3.xfrom
mdeboer wants to merge 1 commit intopestphp:3.xfrom
Conversation
Author
|
Please let me know if you want me to fix the merge conflicts. This PR hasn't had any attention so far afaik. So please, let me know if you want me to do anything. |
Author
|
@nunomaduro Just a friendly reminder. It would be nice if someone could take a look at this as the original issue was opened on December 14 2024. |
Member
|
this is fixed on the upcoming 4.x branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
This fixes cases where running pest with
--fail-on-incomplete(and possibly other--fail-onarguments) returns an exit code of 0 (success) instead of 1 (error).Related:
--fail-on-incompletedoesn't cause exit code to be non-zero when snapshots are missing #1328