Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Add toHaveAttribute expectation #934

Merged
merged 3 commits into from
Sep 3, 2023
Merged

[2.x] Add toHaveAttribute expectation #934

merged 3 commits into from
Sep 3, 2023

Conversation

hungthai1401
Copy link
Contributor

What:

  • Bug Fix
  • New Feature

Description:

This PR adds toHaveAttribute expectation

Usage:

test('commands must have AsCommand attribute')
    ->expect('App\Console\Commands')
    ->toHaveAttribute('Symfony\Component\Console\Attribute\AsCommand');

Related:

owenvoke
owenvoke reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a useful new addition, I just have one thought. 👍🏻

src/Expectation.php Outdated Show resolved Hide resolved
@devajmeireles
Copy link
Member

Waiting the final review to write the docs.

@devajmeireles devajmeireles mentioned this pull request Sep 3, 2023
Merged
@devajmeireles
Copy link
Member

Waiting the final review to write the docs.

Doc ready: pestphp/docs#224

@nunomaduro nunomaduro merged commit 0fc232b into pestphp:2.x Sep 3, 2023
20 checks passed
@hungthai1401
Copy link
Contributor Author

@devajmeireles @devajmeireles thanks

@hungthai1401 hungthai1401 deleted the to_have_attribute_expectation branch September 4, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

@devajmeireles devajmeireles devajmeireles approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hungthai1401 @devajmeireles @owenvoke @nunomaduro