Skip to content

feat: limit code and id fields to 7 characters #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeonardooFattori wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: limit code and id fields to 7 characters #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/features/review/planning-protocol/components/common/inputs/text/AddTextTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ export default function AddTextTable({ text, placeholder, referencePrefix = "",
return (
<FormControl sx={label}>
<FormControl sx={formcontrol}>
<FormLabel mt={"30px"} fontWeight={500} fontSize={"large"}> {text} </FormLabel>
<FormLabel mt={"30px"} fontWeight={500} fontSize={"large"}>
{" "}
{text}{" "}
</FormLabel>
<InfosTable
typeField={""}
onAddText={(value) => handleAddText(value)}
Expand All @@ -27,6 +30,7 @@ export default function AddTextTable({ text, placeholder, referencePrefix = "",
placeholder={placeholder}
referencePrefix={referencePrefix}
enableReferenceCode={enableReferenceCode}
maxLength={7}
/>
</FormControl>
</FormControl>
Expand Down
4 changes: 4 additions & 0 deletions src/features/review/planning-protocol/components/common/tables/InfosTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ interface InfosTableProps {
placeholder: string;
referencePrefix?: string;
enableReferenceCode?: boolean;
maxLength?: number;
}

export default function InfosTable({
Expand All @@ -27,6 +28,7 @@ export default function InfosTable({
placeholder,
referencePrefix = "",
enableReferenceCode = true,
maxLength,
}: InfosTableProps) {
const { sendAddText } = useCreateProtocol();

Expand Down Expand Up @@ -134,6 +136,7 @@ export default function InfosTable({
placeholder={`${referencePrefix}-01`}
value={referenceCode}
onChange={(e) => setReferenceCode(e.target.value)}
maxLength={maxLength}
onBlur={() =>
setReferenceCode((s) => s.trim().toUpperCase())
}
Expand Down Expand Up @@ -173,6 +176,7 @@ export default function InfosTable({
<Input
value={editedCode}
onChange={(e) => setEditedCode(e.target.value)}
maxLength={maxLength}
onBlur={() =>
setEditedCode((c) => c.trim().toUpperCase())
}
Expand Down
7 changes: 3 additions & 4 deletions src/features/review/planning-protocol/components/common/tables/InteractiveTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,9 @@ export default function InteractiveTable({ id, url, label }: Props) {
}

const handleIdChange = (index: number, newId: string) => {
const limitedId = newId.slice(0, 7);
setRows((prevRows) =>
prevRows.map((row, i) => (i === index ? { ...row, id: newId } : row))
prevRows.map((row, i) => (i === index ? { ...row, id: limitedId } : row))
);
};

Expand All @@ -267,14 +268,12 @@ export default function InteractiveTable({ id, url, label }: Props) {
<Input
value={row.id}
onChange={(e) => handleIdChange(index, e.target.value)}

maxLength={7}
isReadOnly={!isEditing}

border={isEditing ? "solid 1px #303D50" : "transparent"}
bg={isEditing ? "white" : "transparent"}
cursor={isEditing ? "text" : "default"}
_focus={{ boxShadow: isEditing ? "outline" : "none" }}

borderRadius="md"
size="sm"
/>
Expand Down